-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add builder for libX11 #42
Conversation
|
||
# The products that we will ensure are always built | ||
products(prefix) = [ | ||
LibraryProduct(prefix, "libX11", :libX11), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These actually all these libraries:
libX11
libX11-xcb
libXau
libxcb-composite
libxcb-damage
libxcb-dpms
libxcb-dri2
libxcb-dri3
libxcb-glx
libxcb-present
libxcb-randr
libxcb-record
libxcb-render
libxcb-res
libxcb-screensaver
libxcb-shape
libxcb-shm
libxcb
libxcb-sync
libxcb-xf86dri
libxcb-xfixes
libxcb-xinerama
libxcb-xinput
libxcb-xkb
libxcb-xtest
libxcb-xvmc
libxcb-xv
I listed only the two related with x11
./configure --prefix=${prefix} --host=${target} ${EXTRA_OPTS} | ||
if [[ "${dir}" == libX11-* ]]; then | ||
# For some obscure reason, this Makefile may not get the value of CPPFLAGS | ||
sed -i "s?CPPFLAGS = ?CPPFLAGS = ${CPPFLAGS}?" src/util/Makefile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't want to look into why the Makefile wasn't getting the right value, it's strange because it worked for some builds, it started failing with Linux(:aarch64, libc=:glibc)
I'm having some trouble building this locally; first the build system fails to find After I do that, I get the following configure error for
|
Yes, I am. Latest BB includes this: JuliaPackaging/BinaryBuilder.jl#423 I remember getting the error about missing |
It's working for all platforms, excluding x86_64 Windows. We get the following error:
We can either ignore the error or fix it, now I'm exhausted and can't look into this.
Edit: even with
make CFLAGS="-WNO-error=pointer-to-int-cast"
I'm getting a ton of other errors (real errors, not something triggered by-Werror
) 😕